[Bug 8138] Per-dir merge files not reloaded properly when switching source args with --i-r

samba-bugs at samba.org samba-bugs at samba.org
Sat Jun 18 12:48:12 MDT 2011


--- Comment #2 from Matt McCutchen <matt at mattmccutchen.net> 2011-06-18 18:48:12 UTC ---
(In reply to comment #1)
> A fix on the sending side would require that the curr_dir path be noticed to be
> different, and a full pop of all filters be done, followed by a full push of
> all filters for the new curr_dir path plus the in-transfer path.

Right, that's what I would like rsync to do for my use case.

> There is a similar (but not identical) effect on the receiving side since it
> can get only one version of each combined directory's filter files.

Only if the per-dir merge rule applies to the receiving side, and then the user
can avoid the problem by using a different per-dir merge file name for each
source arg.  As you suggest, this is not the same bug but rather a consequence
of the receiver's use of the overlaid view of the merge files prepared by the
sender.  I wouldn't consider it grounds not to fix the sender case.  (Of
course, you can do whatever you want and I can fork if I care enough.)

To really fix this, rsync could have a mode where the sender sends the
generator its combined view of the receiving-side per-dir filters for each
file-list directory.  That would also remove the need to use --delete-after. 
But it is a separate enhancement proposal.

Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

More information about the rsync mailing list