[PATCH] One more -x to not traverse cyclic bind-mounts

Jeff Hansen jhansen at cardaccess-inc.com
Wed Jan 19 12:56:06 MST 2011

On 01/19/2011 12:52 PM, Matt McCutchen wrote:
> On Wed, 2011-01-19 at 12:40 -0700, Jeff Hansen wrote:
>> The way rsync determines if the directory is a mount point looks very
>> portable to me (with the FLAG_TOP_DIR bit), and with this patch, it
>> has worked on every Linux system I've tried so far (not sure if
>> FLAG_TOP_DIR works on BSDs, but I'm guessing it does).
> FLAG_TOP_DIR has nothing whatsoever to do with mount points.  Try the
> following test:
> $ mkdir -p src/foo
> $ rsync -axxx src/ dest/
> You'll find that your patch excludes "src/foo", which is on the same
> filesystem as "src".

OK, you're right.  I'll keep looking for a correct, portable way to 
detect bind-ish mounts.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 5622 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://lists.samba.org/pipermail/rsync/attachments/20110119/e9fa6c00/attachment.bin>

More information about the rsync mailing list