DO NOT REPLY [Bug 7194] Getting --inplace and --sparse to work together (+patch)

samba-bugs at samba-bugs at
Thu Jan 13 08:53:55 MST 2011

wayned at changed:

           What    |Removed                     |Added
             Status|NEW                         |ASSIGNED

------- Comment #4 from wayned at  2011-01-13 09:53 CST -------
An improvement like this seems good for 3.1.0.  Your patch looks nice, but I do
want to make sure that it is leveraging knowledge from the generator -- if
we're doing a normal (not whole-file) transfer, then a seek over identical
bytes doesn't need to read the bytes again.  Does you patch take that into

Also, there's already a change in the 3.1.0dev code in sparse_end() that
replaces that write-a-0-at-the-end-of-the-file code with an ftruncate() call
(if ftruncate() is available), which will avoid allocating an extra block at
the end of the file to hold the 0.

Configure bugmail:
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

More information about the rsync mailing list