DO NOT REPLY [Bug 3649] buffer overflow in receive_file_entry

[samba-bugs at samba.org]

https://bugzilla.samba.org/show_bug.cgi?id=3649


wayned at samba.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |WORKSFORME




------- Comment #3 from wayned at samba.org  2011-01-03 18:50 CST -------
The original error was for an impossibly large filename length, and thus an
indication of a protocol issue.  If increasing the receive buffer size to
something bigger makes rsync work, that is an indication that your system files
are buggy, because any string larger than MAXPATHLEN should not be accepted by
things like open().

So, for the issue reported by Daniel, the correct fix is not to change rsync,
but to get the system include files fixed.  Failing that, you could kluge a
larger, more correct value for MAXPATHLEN in rsync.h using a combination of
#undef MAXPATHLEN and #define MAXPATHLEN
<some-larger-but-still-supported-by-the-filesystem-functions-buffer-len-value>.

As before, if someone has a reproducible case for an actual protocol error,
please let us know.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.