[Bug 8336] --implied-dirs should include the file-list root by default

samba-bugs at samba.org samba-bugs at samba.org
Mon Aug 1 06:05:06 MDT 2011


Matt McCutchen <matt at mattmccutchen.net> changed:

           What    |Removed                     |Added
             Status|RESOLVED                    |REOPENED
         Resolution|WONTFIX                     |

--- Comment #3 from Matt McCutchen <matt at mattmccutchen.net> 2011-08-01 12:05:06 UTC ---
(In reply to comment #2)
> If you move the dot prior to sourcedir in the source arg
> (/a/./sourcedir/dirtree/to/transfer) and omit sourcedir in the dest
> (foo::module/a/), then sourcedir will get its attributes set by the transfer.

And a specially prepared symlink would be needed for the --link-dest to work;
that's why I prefer my method.

> As for why the root dir doesn't get set by the transfer, it's because that
> directory is not being sent, just specific files within it.

That rationale does not fully justify the behavior with -R.  If I do "rsync -R
sub/foo sub/bar dest/", I could make the exact same argument that "sub is not
being sent, just specific files within it", yet "sub" is included as an implied
dir.  If you think of file-list space as a tree, then a source arg that targets
a particular node of the tree will pick up all the ancestors as implied dirs --
except the root.  In that sense, the behavior seems pretty arbitrary.  IMO,
rsync should include all of the ancestors or none of them.

Without -R, since there can only be one component of path info on the source
and "rsync /path/to/item dest/" to put the "item" in the "dest" without
extraneous effects is very traditional usage, the current behavior makes sense.
 But leaving --implied-dirs off by default when -R is off would be enough to
maintain this behavior with my proposed change.

I'm reopening because I have refuted the justification you put forth.  You're
welcome to WONTFIX again as your prerogative, which leaves me with the usual
option (fork if I care enough).

Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

More information about the rsync mailing list