[Bug 8053] New: Older C compilers don't allow in-line declarations flist.c:1653

[samba-bugs at samba.org]

https://bugzilla.samba.org/show_bug.cgi?id=8053

           Summary: Older C compilers don't allow in-line declarations
                    flist.c:1653
           Product: rsync
           Version: 3.0.8
          Platform: All
        OS/Version: FreeBSD
            Status: NEW
          Severity: minor
          Priority: P5
         Component: core
        AssignedTo: wayned at samba.org
        ReportedBy: kevin.braunsdorf at gmail.com
         QAContact: rsync-qa at samba.org


The build for rsync fails on FreeBSD with older gcc versions due to
a syntax error.  This

A pure C compiler doesn't allow C++ style in-line declarations, we need
a curly brace to scope the declaration of name_len here:

--- flist.c     Mon Feb 21 12:20:58 2011
+++ ../flist.c  Fri Apr  1 12:33:18 2011
@@ -1651,4 +1651,5 @@
                    || (dname[1] == '.' && dname[2] == '\0')))
                        continue;
+               {
                unsigned name_len = strlcpy(p, dname, remainder);
                if (name_len >= remainder) {
@@ -1671,4 +1672,5 @@

                send_file_name(f, flist, fbuf, NULL, flags, filter_level);
+               }
        }

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.