DO NOT REPLY [Bug 7057] Buffer overflow when sending a file with long name

[samba-bugs at samba.org]

https://bugzilla.samba.org/show_bug.cgi?id=7057


jzeleny at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
Attachment #5215 is|0                           |1
           obsolete|                            |




------- Comment #8 from jzeleny at redhat.com  2010-03-24 08:54 CST -------
Created an attachment (id=5530)
 --> (https://bugzilla.samba.org/attachment.cgi?id=5530&action=view)
Rewritten patch doing boundary check

I didn't manage to reproduce the issue either, but I went ahead and traced the
issue step by step. You were right, the problem is when the path is
MAXPATHLEN-1 characters long, I just didn't pinpoint the problematic place in
code accurately before. I put together another patch, I'm sending in
attachment. What do you think of it? Output of fixed rsync run by your
reproducer is:

$ rsync -n -a src/ dest/
Directory path too long
rsync error: some files/attrs were not transferred (see previous errors) (code
23) at main.c(1042) [sender=3.0.7]

I know it's the simplest solution, but I think it's acceptable. Of course I
based it on an assumption, that OS will have problems with paths longer than
MAXPATHLEN anyway. Or am I mistaken?


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.