3.1: bug in --stats

Wayne Davison wayned at samba.org
Sat Jun 26 10:02:25 MDT 2010


On Mon, May 3, 2010 at 8:30 AM, Carlos Carvalho <carlos at fisica.ufpr.br>wrote:

> 3.1, including the latest version, produces bogus ---stats output: [...]
> Total file size: -6,417,895,484,864,819,269 bytes
>

This turned out to be an issue with with the F_LENGTH() accessor for a large
file that had a nano-second modified time stored.  Such a file would also
get the wrong nano-second part of the modified time.  This is now fixed in
git.

BTW, why aren't these fields [...] of type size_t?
>

Because size_t can be only 32-bit on some older machines.  It would be
better if they were uint64 than int64, but that type isn't currently
determined by the configuration code.  However, having 63 bits for the
totals is currently adequate.

..wayne..
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.samba.org/pipermail/rsync/attachments/20100626/fc3526d3/attachment.html>


More information about the rsync mailing list