DO NOT REPLY [Bug 7869] rsync segfault

[samba-bugs at samba.org]

https://bugzilla.samba.org/show_bug.cgi?id=7869





------- Comment #3 from matt at mattmccutchen.net  2010-12-15 13:32 CST -------
I see what is happening.  options.c:1496:

backup_dir_remainder = sizeof backup_dir_buf - backup_dir_len;
if (backup_dir_remainder < 32) {
        snprintf(err_buf, sizeof err_buf,
                "the --backup-dir path is WAY too long.\n");
        return 0;
}

But backup_dir_remainder is unsigned, so the subtraction overflows and the
error message does not trip.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.