DO NOT REPLY [Bug 5583] Don't write out an unchanged file if all the checksums matched

[samba-bugs at samba.org]

https://bugzilla.samba.org/show_bug.cgi?id=5583


henrik-rsync at prak.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |henrik-rsync at prak.org




------- Comment #4 from henrik-rsync at prak.org  2009-11-13 04:49 CST -------
Here's my "me too" comment on the issue (feel free to move it to a separate bug
depending on this one):

I have stumbled upon the same issue in connection with rsnapshot and rsync with
the "--detect-renamed" patch. 

Basically rsnapshot works like this: On the first run creates a full copy of a
directory tree /src to /dst/0. Then the next time it rotates /dst/(x) to
/dst/(x+1) and creates a copy with just hard links from /dst/1 to /dst/0 and
then calls rsync to transfer the changes between /src and /dst/0, effectively
creating a differential backup at the granularity of files.

I applied the detect-renamed patch to avoid multiple copies of big files when
they are moved around in the directory tree. 

The patch works in so far as it finds the correct base files in /dst.
Then it uses the delta algorithm to make sure that no coincidental match of
filename,size and mtime results in a false positive.

Unfortunately usage of the delta algorithm creates a new copy of the file at
/dst even if the content is the same as the base file (instead of using a
hardlink to the base file).


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.