DO NOT REPLY [Bug 6881] New: --bwlimit option uses KiB/s, but is documented as (what amounts to) kB/s

[samba-bugs at samba.org]

https://bugzilla.samba.org/show_bug.cgi?id=6881

           Summary: --bwlimit option uses KiB/s, but is documented as (what
                    amounts to) kB/s
           Product: rsync
           Version: 3.1.0
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: trivial
          Priority: P3
         Component: core
        AssignedTo: wayned at samba.org
        ReportedBy: rlaager at wiktel.com
         QAContact: rsync-qa at samba.org


The --bwlimit option seems to use KiB/s, as io.c's sleep_for_bwlimit() function
divides by 1024. It's documented as "KBPS", "KBytes per second", and "kilobytes
per second".

I'm going to attach a patch which standardizes all of this as KiB/s and
"kibibytes per second", to match the actual usage.

Given that this is a network transfer rate, it'd be more proper (and consistent
with other applications) to change the function to work in SI kilobytes per
second (i.e. use 1000 instead of 1024), but that's backwards-incompatible. If
you'd like to go this route, I can prepare a patch to that effect.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.