DO NOT REPLY [Bug 6378] "rsync -v -rsync -v --inplace --progress --rsh=ssh -a" reports erroneous and completely unrealistic transferred size

samba-bugs at samba.org samba-bugs at samba.org
Thu May 28 14:25:34 GMT 2009


https://bugzilla.samba.org/show_bug.cgi?id=6378





------- Comment #3 from matt at mattmccutchen.net  2009-05-28 09:25 CST -------
I see what is going on here.  In the current rsync implementation, progress is
always computed by the client, which in this case is the sender.  The local ssh
process has a 2 MB buffer for outgoing data (see CHAN_SES_WINDOW_DEFAULT in
http://www.openbsd.org/cgi-bin/cvsweb/src/usr.bin/ssh/channels.h?rev=1.98;content-type=text%2Fx-cvsweb-markup
).  The rsync sender fills up this buffer with data and counts that as 2 MB of
progress.

The obvious approach to fixing this would be to always have the receiver
compute progress, which would involve a protocol change.  The problem is that,
since rsync is pipelined, while the receiver is reporting progress for one
file, the sender may have moved on to another file.  Thus, to get consistent
output, the sender would have to wait to output a filename until it gets
acknowledgment that the receiver has started to receive the file.  And that has
a minor security ramification: a user who realizes that the source directory
contains a file the remote server shouldn't see and interrupts rsync can no
longer assume that the information has not been compromised if the name of the
secret file was not in the output.  Thoughts?


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.


More information about the rsync mailing list