does --whole-file always work?

[Matt McCutchen]

On Thu, 2009-05-14 at 15:59 +0300, Amir Rapson wrote:
> Running rsync with --whole-file yields poorer performance results than
> a simple "cp". 
> Looking at the code - it looks like "copy_file" isn't really called
> when I add the --whole-file flag. The regular "receive_data" is doing
> the copy.

That's right.  In the current design, file transfers are always done
over the connection between the sender and receiver and copy_file is
used only for copies within the destination (which happen with a few
options such as --copy-dest).  It would be possible to make a special
case for local runs and have the receiver open the source file directly
(or something like that), but this has not been done yet.

-- 
Matt