DO NOT REPLY [Bug 6276] crtimes.patch does not preserve creation dates on Mac x86_64 only

[samba-bugs at samba.org]

https://bugzilla.samba.org/show_bug.cgi?id=6276


bugzilla.samba.org at maclemon.at changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|WORKSFORME                  |




------- Comment #5 from bugzilla.samba.org at maclemon.at  2009-05-10 15:02 CST -------
Retested with rsync 3.0.6 release version, and x86_64 on Mac OS X still does
NOT preserve creation dates with the crtimes.patch.

This time I've created a single (non-fat) binary for testing.

Apply patches:
patch -p1 <../patches/fileflags.diff
./prepare-source
patch -p1 <../patches/crtimes.diff


This is how I configure:
./configure --prefix=/usr/local/maclemon-beta --disable-debug CC="gcc
-std=gnu99 -mmacosx-version-min=10.4 -isysroot /Developer/SDKs/MacOSX10.4u.sdk"
CFLAGS="-g -fprefetch-loop-arrays -funroll-loops -O3 -DHAVE_CONFIG_H -Wall -W
-I./popt -isysroot /Developer/SDKs/MacOSX10.4u.sdk -arch x86_64"
LDFLAGS="-mmacosx-version-min=10.4 -arch x86_64"

MD5 (rsync) = 6aab05fca8e521e8a6afa2d2099e7f85
SHA1(rsync)= 89f0f988ee01cf96ce5da22a249142545d426008
rsync: Mach-O 64-bit executable x86_64
-rwxr-xr-x  1 pepi  staff  650544 10 Mai 21:44 rsync

When testing crtimes with "make test" the test does pass. Yet when copying a
file with rsync x86_64 on 10.5.6 the creation time of the copied file is set to
the modification date of the file.

Output of "make test"
$ sudo make test
pepi > root at marvelousmonolith.maclemon.lan Password: 
rsync_bin=`pwd`/rsync ./runtests.sh
============================================================
./runtests.sh running in /Users/pepi/unix/rsync/rsync-3.0.6/rsync-3.0.6
    rsync_bin=/Users/pepi/unix/rsync/rsync-3.0.6/rsync-3.0.6/rsync 
    srcdir=/Users/pepi/unix/rsync/rsync-3.0.6/rsync-3.0.6
    TLS_ARGS= -L
    testuser=root
    os=Darwin marvelousmonolith.maclemon.lan 9.6.2 Darwin Kernel Version 9.6.2:
Tue Jan 13 20:42:22 PST 2009; root:xnu-1228.9.80~1/RELEASE_I386 i386
    preserve_scratch=no
    scratchbase=/Users/pepi/unix/rsync/rsync-3.0.6/rsync-3.0.6/testtmp
PASS    00-hello
PASS    acls
PASS    backup
PASS    batch-mode
PASS    chgrp
PASS    chmod-option
SKIP    chmod-temp-dir (Can't find a tmp dir on a different file system)
PASS    chmod
SKIP    chown-fake (Can't chown (probably need root))
PASS    chown
PASS    compare-dest
PASS    crtimes
PASS    daemon-gzip-download
PASS    daemon-gzip-upload
PASS    daemon
SKIP    default-acls (I don't know how to use your setfacl command)
PASS    delete
SKIP    devices-fake (Can't create char device node)
PASS    devices
SKIP    dir-sgid (Your filesystem doesn't use directory setgid; maybe it's
BSD.)
PASS    duplicates
PASS    exclude
PASS    executability
PASS    files-from
PASS    fuzzy
PASS    hands
PASS    hardlinks
PASS    itemize
PASS    longdir
PASS    merge
PASS    missing
PASS    relative
PASS    ssh-basic
PASS    symlink-ignore
PASS    trimslash
PASS    unsafe-byname
PASS    unsafe-links
PASS    wildmatch
SKIP    xattrs (Unable to set an xattr)
------------------------------------------------------------
----- overall results:
      33 passed
      6 skipped
------------------------------------------------------------
overall result is 0




Testing with backoup bouncer 0.1.3:
This copier produced log output in:
   /Volumes/Dst/81-rsync3-maclemon-beta/log
Verifying:    basic-permissions ... ok (Critical)
Verifying:           timestamps ... ok (Critical)
Verifying:             symlinks ... ok (Critical)
Verifying:    symlink-ownership ... ok 
Verifying:            hardlinks ... ok (Important)
Verifying:       resource-forks ... 
   Sub-test:             on files ... ok (Critical)
   Sub-test:  on hardlinked files ... ok (Important)
Verifying:         finder-flags ... ok (Critical)
Verifying:         finder-locks ... ok 
Verifying:        creation-date ... FAIL 
Verifying:            bsd-flags ... ok 
Verifying:       extended-attrs ... 
   Sub-test:             on files ... ok (Important)
   Sub-test:       on directories ... ok (Important)
   Sub-test:          on symlinks ... ok 
Verifying: access-control-lists ... 
   Sub-test:             on files ... ok (Important)
   Sub-test:              on dirs ... ok (Important)
Verifying:                 fifo ... ok 
Verifying:              devices ... ok 
Verifying:          combo-tests ... 
   Sub-test:  xattrs + rsrc forks ... ok 
   Sub-test:     lots of metadata ... ok 

Logs from the backup bouncer and rsync output are attached.
The identical way to configure and build rsync as i386 (32bit) works fine for
all creation timestamp tests. Be that with make test or by manually checking in
the filesystem. x86_64 fails.

All tests were done as root.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.