DO NOT REPLY [Bug 6027] Error when rsync encounters empty symlinks
samba-bugs at samba.org
samba-bugs at samba.org
Wed Jan 14 04:36:44 GMT 2009
https://bugzilla.samba.org/show_bug.cgi?id=6027
------- Comment #2 from matt at mattmccutchen.net 2009-01-13 22:36 CST -------
In general, rsync is not designed to cope with corrupt filesystems, but if it
handles a file with an empty name, I suppose it should handle this too. I had
a slightly different patch:
https://mattmccutchen.net/rsync/rsync.git/commitdiff/7c18847f1608618134ffd166d97952177502d998
The place where the code is hooked is a matter of taste; I preferred to catch
the invalid data as soon as possible to avoid any potential surprises. On the
other hand, the error message definitely needs to be more clearly distinct from
the "symlink has no referent" message that can happen with --copy-links.
It may not be easy to test the code on a true empty symlink, but I at least saw
the code path in action by temporarily hacking readlink_stat to substitute an
empty string as the target if the symlink's name began with "z". :)
--
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the rsync
mailing list