[Code study]should we remove if (motd && *motd) section?

Paul Slootman paul+rsync at wurtel.net
Mon Apr 27 10:41:32 GMT 2009


On Mon 27 Apr 2009, Daniel.Li wrote:
> 
> I'm confused when we will run into "if (motd && *motd)"? 
> 
> As I have found that Globals is set 0 during initialization, and I
> didn't find anywhere else assign the value.

> clientserver.c #line 147~160
> > 	if (!am_client) {
> > 		motd = lp_motd_file();
                ^^^^^^^^^^^^^^^^^^^^^^
> > 		if (motd && *motd) {

It's being assigned the line above the (motd && *motd) part!


Paul


More information about the rsync mailing list