DO NOT REPLY [Bug 6280] (Bug incl. PATCH) Linux mknod does not work when syncing fifos and sockets from Solaris

[samba-bugs at samba.org]

https://bugzilla.samba.org/show_bug.cgi?id=6280


wayned at samba.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED




------- Comment #2 from wayned at samba.org  2009-04-24 09:08 CST -------
Does Solaris allow mknod("test_fifo_fifi", 0777 | S_IFIFO, (dev_t)0) to work? 
If so, the fix I'm contemplating is setting rdev to 0 down in flist.c's
make_file():

#ifdef HAVE_STRUCT_STAT_ST_RDEV
        if (IS_DEVICE(st.st_mode)) {
                tmp_rdev = st.st_rdev;
                st.st_size = 0;
        } else if (IS_SPECIAL(st.st_mode)) {
                tmp_rdev = 0;
                st.st_size = 0;
        }
#endif

I wonder if that would break any OS?  Perhaps a safer change would be for that
final tmp_rdev assignment to be:

                tmp_rdev = st.st_rdev == (dev_t)-1 ? 0 : st.st_rdev;


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.