DO NOT REPLY [Bug 6280] New: (Bug incl. PATCH) Linux mknod does not work when syncing fifos and sockets from Solaris

[samba-bugs at samba.org]

https://bugzilla.samba.org/show_bug.cgi?id=6280

           Summary: (Bug incl. PATCH) Linux mknod does not work when syncing
                    fifos and sockets from Solaris
           Product: rsync
           Version: 3.0.6
          Platform: x64
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P3
         Component: core
        AssignedTo: wayned at samba.org
        ReportedBy: sebastian_kapfer at gmx.net
         QAContact: rsync-qa at samba.org


When syncing specials, namely pipes and sockets from a Solaris host, rsync -a
prints error 22.  Remote version is 2.6.3pre1.


sk at noether(~/rsnyc/rsync-3.0.6pre1)> ./rsync -a klein:/tmp/xhyjxhy .
rsync: mknod "/home/sk/rsnyc/rsync-3.0.6pre1/xhyjxhy" failed: Invalid argument
(22)
rsync error: some files/attrs were not transferred (see previous errors) (code
23) at main.c(1505) [generator=3.0.6pre1]


Reason:  rsync calls mknod ("filename", ..., 0xffffffff), which Linux rejects,
as allowed by POSIX.

rsync should clear the third parameter before calling mknod.

Suggested patch in syscall.c, do_mknod:

111 #ifdef HAVE_MKNOD
112         if (S_ISSOCK (mode) || S_ISFIFO(mode)) {
113             /* this variable is not ignored by Linux 2.6. */
114             dev = 0;
115         }
116 >-------return mknod(pathname, mode, dev);
117 #else


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.