crtimes discrepancy on PPC

Wayne Davison wayned at
Mon Sep 29 21:47:53 GMT 2008

On Mon, Sep 29, 2008 at 09:49:26AM -0500, Mike Bombich wrote:
> 1) cmp_time (util.c) doesn't check for negative values provided in file1 or 
> file2.  If file2 is positive, and file1 is negative, and 
> absolute_value(file1) > file2, cmp_time returns 0, even though the times 
> are obviously different.

Yeah, that's a subtle one.  I've changed it in a little simpler way:
reordering the args in the ifs so that an underflow can't trigger a
spurious successful test.  Patch attached.

> 2) set_file_attrs (rsync.c) doesn't initialize sx2.crtime (e.g. when the 
> sxp argument is NULL).

Thanks!  I've applied that change to the crtimes diff.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: cmp_time.diff
Type: text/x-diff
Size: 350 bytes
Desc: not available
Url :

More information about the rsync mailing list