DO NOT REPLY [Bug 5448] rsync modifies files in place even without --inplace specified

samba-bugs at samba.org samba-bugs at samba.org
Thu May 8 01:23:13 GMT 2008


https://bugzilla.samba.org/show_bug.cgi?id=5448





------- Comment #1 from sites-samba at carlthompson.net  2008-05-07 20:23 CST -------
Created an attachment (id=3280)
 --> (https://bugzilla.samba.org/attachment.cgi?id=3280&action=view)
A patch to correct this behavior

Attached is a patch to version 3.0.2 to correct this behavior. This patch
causes rsync to honor the absence of the "--inplace" option for permission,
owner and group changes. This patch is a greatly simplified version of Matt
McCutchen's excellent "tweak-opts" patch found in his git repository
(http://mattmccutchen.net/rsync/rsync.git/?a=shortlog;h=refs/heads/tweak-opts).
However this patch does not add any new options.

It's my opinion that this simple patch makes any rsync-based backup system that
uses hard links (as so many do) more reliable and robust and significantly
helps maintain the integrity of the backups. It does not require any changes to
the configuration or use of the clients, server or backup system to achieve
this benefit.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.


More information about the rsync mailing list