Rsync itemizing "p" even when -p, -E are off

Wayne Davison wayned at
Mon Mar 10 03:01:23 GMT 2008

On Sat, Mar 08, 2008 at 11:53:50AM -0500, Matt McCutchen wrote:
> It turns out that just restoring the condition isn't enough,
> as rsync still incorrectly itemizes 'p' when -E is on and an
> alternate basis file differs from the destination file-to-be
> in permissions but not in executability:

Sure does.  I've checked in a fix for this.

> This would be a great opportunity to factor out a lot of the
> attribute-comparing code that is duplicated in "itemize" and
> "unchanged_attrs" in order to reduce the risk of discrepancies
> between them in the future and make it simpler to add support
> for a new attribute to rsync.

That's a good idea.  I took a look at it, and the two function
have some differences in scope that make this a little tricky,
but it shouldn't be too bad.  I don't think I'll tackle that
prior to 3.0.1, though.


More information about the rsync mailing list