[PATCH] Fix backwards comment about logging on a local run.

Matt McCutchen matt at mattmccutchen.net
Thu Jan 31 00:20:44 GMT 2008

On Wed, 2008-01-30 at 16:04 -0800, Wayne Davison wrote:
> On Tue, Jan 29, 2008 at 09:45:08PM -0500, Matt McCutchen wrote:
> > Since the process executing the code inside the previous "if" (which
> > doesn't close the log file) sets am_server = 1, I think the comment is
> > backwards.
> No, it's saying (or attempting to say) that the client will handle the
> logging, so the server is closing the logfile.

I understand what the comment is currently attempting to say.  My point
is that, unless I am misreading the code, the log-closing code is
reached by the client and not by the server (which enters the body of
the "if (pid == 0)" block, sets am_server = 1, and calls child_main,
which presumably exits the process without returning).  Since the client
closes the log, the server is doing the logging.


More information about the rsync mailing list