rsync 3.00pre6 segfault in add_dirs_to_tree

[Ming Zhang]

Hi Matt


No news is good news, so far Q&A and I have never seen crash again.
Thanks a lot for the fix!

Ming


On Mon, 2008-01-14 at 17:12 -0500, Matt McCutchen wrote:
> On Fri, 2007-12-14 at 13:34 -0500, Ming Zhang wrote:
> > sorry but seems it still crashes somehow.
> > 
> > global dir_count is 23.
> > 
> > (gdb) bt
> > #0  0x000000000040544a in add_dirs_to_tree (parent_ndx=10,
> > from_flist=0x57c5d0, dir_cnt=4) at flist.c:1423
> > #1  0x00000000004090ef in send_extra_file_list (f=17, at_least=1000) at
> > flist.c:1729
> > #2  0x00000000004122f3 in send_files (f_in=17, f_out=17) at sender.c:189
> > #3  0x0000000000419087 in client_run (f_in=17, f_out=17, pid=-1, argc=1,
> > argv=0x56c230) at main.c:1041
> > #4  0x000000000041a09a in main (argc=2, argv=0x56c230) at main.c:1260
> > (gdb) bt f
> > #0  0x000000000040544a in add_dirs_to_tree (parent_ndx=10,
> > from_flist=0x57c5d0, dir_cnt=4) at flist.c:1423
> >         file = (struct file_struct *) 0x13
> >         i = 0
> >         dp = (int32_t *) 0x0
> >         parent_dp = (int32_t *) 0x2a983f3c68
> > #1  0x00000000004090ef in send_extra_file_list (f=17, at_least=1000) at
> > flist.c:1729
> >         file = Variable "file" is not available.
> > (gdb) p *(struct file_list *)0x57c5d0
> > $4 = {next = 0x0, prev = 0x57c570, files = 0x0, sorted = 0x0, file_pool
> > = 0x56da70, pool_boundary = 0x2a984f5138, used = 0, malloced = 0, low =
> > 0, high = -1, ndx_start = 192, ndx_end = 187, 
> >   parent_ndx = 10, in_progress = 0, to_redo = 0}
> 
> Ming, can you still reproduce this crash with the latest development
> rsync?  If so, I hope Wayne will investigate it before rsync 3.0.0 is
> released.
> 
> Matt
> 
-- 
Ming Zhang


@#$%^ purging memory... (*!%
http://blackmagic02881.wordpress.com/
http://www.linkedin.com/in/blackmagic02881
--------------------------------------------