Revised flags patch

Wayne Davison wayned at
Sat Feb 16 01:31:45 GMT 2008

On Fri, Feb 15, 2008 at 09:04:48PM +0100, Rolf Grossmann wrote:
> attached is the version of the flags patch, that is based on the one
> I'm using

Your patch calls chflags(file,0) on every file/dir that is going to be
removed or renamed.  Does that slow things down at all?

My current flags patch tries to only call chflags() on the files that
need it, but it that code is only active if the user is preserving
flags, so the forceful chflags()  call may be a better choice, assuming
that things aren't significantly slowed down by that.

That change for every rename seems a little more doubtful, as it seems
like it would always turn off all chflags on renamed files when the
--fileflags option isn't specified.


More information about the rsync mailing list