Parent directory creation in recv_files unnecessary?

Matt McCutchen matt at mattmccutchen.net
Sun Oct 28 15:12:54 GMT 2007


Wayne,

Around line 637 of receiver.c, the receiver creates any missing parent
directories of the destination file.  This looks unnecessary because the
generator ensured at line 1206 of generator.c that the parent
directories existed (or encountered an error creating them that is
unlikely to have gone away by the time the receiver processes the file).
The only purpose the receiver's code seems to serve is to create the
temp dir if one is being used, but it doesn't make sense to do that only
if --relative is enabled.  Am I missing something or should the code be
removed?

Matt



More information about the rsync mailing list