DO NOT REPLY [Bug 4764] Wrong include/exclude descriptions

[samba-bugs at samba.org]

https://bugzilla.samba.org/show_bug.cgi?id=4764





------- Comment #7 from tps at vr-web.de  2007-07-05 19:33 CST -------
OK:
+ /some/path/this-file-will-not-be-found
+ /file-is-included
- *

This fails because the parent directory "some" is excluded by the '*' rule, so
rsync never visits any of the files in the "some" or "some/path" directories.''

If I interpret correctly, what this states, it means '/**/6/' is useless
combined with '- *', since no directory will ever be matched, since you are not
expanding first to find a match for '/**/6/'? It is not clear.

The same is with

+ 6/
- *

are you traversing all directories, or just reading the contents of the one we
are in? The manpage states that '+ 6/ finds any directory named '6'. Thus I
assume you traversing all available directories first, looking for one matching
'6'? If this is not true, meaning you are testing within the directory we are
in if there is no match (one named '6') discarding them, never traversing down
the tree?

This is not clearly stated. I am missing a clear description what is matched by
all those rules spawning more than just one directory:

+ **/
+ /**/
+ 6/ (implicitly something like (**/6/)


If you are assuming

/fedora/core/6

you are reading only

/fedora

comparing against '/**/6/'. Since this does not match the '- *' is applied.
This matches. The directory is removed?! I'd assume with

+ /**/6/
- *

you'd try to find a match expanding until there is none. Meaning:

/fedora has subdirectory /core has subdirectory /6, this matches /**/6, since
/**/ matches any path, thus /fedora/core/6 is matched. If this isn't done,
state it clearly. '/**/6' this way will never match anything if followed by a
rule like '- *'.

If you are in need of including only certain deeply nested subdirectories the
includes are not not of use in most cases and the only way transfering deeply
nested directories would be to analyze a whole directory traversal by rsync
feeding the output into grep, sed, or any tool capable of handling strings
efficiently, creating an include file yourself.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.