strange file sizes in log

[Julian Pace Ross]

Cheers Wayne,
Will there be a nightly update?
(cant CVS)

----- Original Message ----- 
From: "Wayne Davison" <wayned at samba.org>
To: "Julian Pace Ross" <linux at prisma.com.mt>
Cc: <rsync at lists.samba.org>
Sent: Tuesday, January 09, 2007 8:09 PM
Subject: Re: strange file sizes in log


> On Tue, Jan 09, 2007 at 10:28:13AM +0100, Julian Pace Ross wrote:
>> Running the EXACT same command on the XP side,
>> *but this time with the --delete option*,
>> [total size doubles]
> 
> Yeah, the total-size value on the daemon side can be inaccurate when it
> is receiving files and a delete operation happens.  This is because the
> current code updates the total size in the make_file() routine, and this
> is called on both the sending side (when sending the file list), and on
> the receiving side (when creating delete lists) -- this is in addition
> to the count that the receiver updates when it is receiving the file
> list.  The client never encounters this problem because it always
> receives the sender's total-size count, overriding any inaccuracy that
> arose.
> 
> I'm going to check-in a change that moves the maintenance of the
> total-size count so that this won't happen.
> 
> Thanks for the report!
> 
> ..wayne..
>