DO NOT REPLY [Bug 4138] New: Incoming chmod can't override inherited directory setgid

samba-bugs at samba-bugs at
Sat Sep 30 16:41:36 GMT 2006

           Summary: Incoming chmod can't override inherited directory setgid
           Product: rsync
           Version: 2.6.9
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P3
         Component: core
        AssignedTo: wayned at
        ReportedBy: hashproduct+rsync at
         QAContact: rsync-qa at

[I mentioned this on the mailing list but nothing happened.  I'm entering it in
Bugzilla so it won't be forgotten.]

When --perms is off, an incoming chmod of "Dg-s" does not prevent new
directories on the receiver from inheriting setgid bits; it probably should. 
Incoming chmod currently takes effect in dest_mode, which is too soon for it to
affect the directory setgid check in set_file_attrs.

To avoid further bugs of this nature, I propose that incoming chmod
should take effect right before the actual call to chmod in
set_file_attrs, as rsyncd-perm once did.

Configure bugmail:
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

More information about the rsync mailing list