protecting files from deletion, and using --delete-excluded

Matt McCutchen hashproduct+rsync at
Fri Sep 1 01:08:53 GMT 2006

On 8/31/06, Wayne Davison <wayned at> wrote:
> I checked in some more code that fixes the latest problem you pointed
> out (the dropping of include/exclude rules read from merge files on the
> receiving side).

I would never have realized that filters might appear before
--delete-excluded on the command line.  I'm glad you added a test.

Tell me if I understand correctly: There are now two checks for
--delete-excluded.  The one in send_rules catches all rules loaded
during command-line processing.  The one in parse_rule_tok catches all
rules loaded after --delete-excluded is seen on the command line,
which includes rules from dir-merge files.  Every rule will be checked
at least once; some might be checked twice, which is fine.

I don't think marking cvsignores as sender-side in parse_rule_tok is
strictly necessary.  Compatibility is only an issue for rules that
will be sent to the remote rsync, and all those go through the check
in send_rules.


More information about the rsync mailing list