Rsync 2.6.9pre2 tries to read ACLs of nonexistent files

Wayne Davison wayned at samba.org
Sat Oct 21 21:03:27 GMT 2006


On Sat, Oct 21, 2006 at 04:27:17PM -0400, Matt McCutchen wrote:
> 		if (preserve_acls && real_ret == 0)
> 			get_acl(fname, &real_sx);

That should be checking fnamecmp, not fname.  I've just commited a fix
for patches/acls.diff.

Let me know what you find out with the assert failure.  Also note that
I fixed a bug in the handling of -H that is only in CVS, not in either
pre-release.  I'll attach the patch that I committed to CVS earlier.

..wayne..
-------------- next part --------------
--- hlink.c	13 Oct 2006 07:48:35 -0000	1.65
+++ hlink.c	17 Oct 2006 18:49:04 -0000	1.66
@@ -83,6 +83,7 @@ static void link_idev_data(void)
 
 			FPTR(cur)->F_HLINDEX = to;
 			FPTR(cur)->F_NEXT = hlink_list[++from];
+			FPTR(cur)->link_u.links->link_dest_used = 0;
 		}
 		pool_free(idev_pool, 0, FPTR(cur)->link_u.idev);
 		if (from > start) {
@@ -94,6 +95,7 @@ static void link_idev_data(void)
 			FPTR(cur)->F_HLINDEX = to;
 			FPTR(cur)->F_NEXT = head;
 			FPTR(cur)->flags |= FLAG_HLINK_EOL;
+			FPTR(cur)->link_u.links->link_dest_used = 0;
 			hlink_list[to++] = head;
 		} else
 			FPTR(cur)->link_u.links = NULL;


More information about the rsync mailing list