Superfluous error msgs: "failed to set times ..."

[Wayne Davison]

On Sun, Nov 12, 2006 at 12:39:55PM +0100, Felix E. Klee wrote:
> AFAICS, these error messages are caused by rsync trying to change the
> time (and permissions, ownership) of symbolic links, which according
> to my knowledge is not possible on Ext2.

Since Linux lacks the lutimes() system function, rsync doesn't even try
to set the modify time on a symlink there.  What OS are you running?

> Is there any way to get rid of these supposedly superfluous error
> messages?

You could try something like the attached patch.

..wayne..
-------------- next part --------------
--- rsync.c	8 Oct 2006 22:02:13 -0000	1.197
+++ rsync.c	12 Nov 2006 14:34:23 -0000
@@ -153,7 +153,7 @@ int set_file_attrs(char *fname, struct f
 	if (!(flags & ATTRS_SKIP_MTIME)
 	    && cmp_time(st->st_mtime, file->modtime) != 0) {
 		int ret = set_modtime(fname, file->modtime, st->st_mode);
-		if (ret < 0) {
+		if (ret < 0 && !S_ISLNK(st->st_mode)) {
 			rsyserr(FERROR, errno, "failed to set times on %s",
 				full_fname(fname));
 			return 0;