DO NOT REPLY [Bug 3584] base64 function does not pad output correctly

samba-bugs at samba.org samba-bugs at samba.org
Mon Mar 6 18:33:50 GMT 2006


https://bugzilla.samba.org/show_bug.cgi?id=3584


wayned at samba.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




------- Comment #2 from wayned at samba.org  2006-03-06 12:33 MST -------
Your change would also affect the password authentication that a daemon rsync
performs, making daemons/clients incompatible with older clients/daemons. 
Also, your code failed to null-terminate the padded value.

I've checked-in an improved version that lets the caller choose if they want
padding or not.  This ensures that only the Proxy-Authentication header is
affected by this change.

Thanks for your help.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.


More information about the rsync mailing list