DO NOT REPLY [Bug 3846] rsync silently transfers blocks of zero bytes on read errors

[samba-bugs at samba.org]

https://bugzilla.samba.org/show_bug.cgi?id=3846





------- Comment #1 from hashproduct+rsync at gmail.com  2006-06-18 19:11 MST -------
Rsync sends zeroes in an attempt to get as much of the new data to the receiver
as possible; one could argue that the receiving rsync should take the data from
the same offset in the basis file instead.  It also sabotages the post-transfer
MD4 checksum on lines 355-357 of match.c:

        /* If we had a read error, send a bad checksum. */
        if (buf && buf->status != 0)
                file_sum[0]++;

That will cause the receiving rsync to delete the temporary file on line 641 of
receiver.c, leaving the old but valid version of the source file intact.  Rsync
will produce a message like this:

   WARNING: <file> failed verification -- update discarded (will try again)

So I don't think there's a problem.  Wayne, please correct me if I am wrong.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.