DO NOT REPLY [Bug 3825] rsync won't delete directory with excluded files

samba-bugs at samba-bugs at
Sun Jun 11 20:00:30 GMT 2006

------- Comment #6 from hashproduct+rsync at  2006-06-11 15:00 MST -------
Created an attachment (id=1955)
 --> (
Proposed changes to deletion, filters, etc.

This patch adds:
- support for --filter="Pp .svn"
- *pinned itemize output and some double-verbose messages for pinned
directories, with or without --dry-run; change get_dirlist, send_directory,
send_file_name, make_file to signal a protected file
- *maxdel itemize output for files spared because of --max-delete
- support for --max-delete=0 to set a deletion limit of zero rather than
disable the limit
- additional error message "could not make way for new <TYPE> at %s" when a
file cannot be deleted to allow another to be created in its place
- delete_item doesn't even try to rmdir a directory containing protected files
(because rsync might be used on an exotic filesystem in which rmdir can delete
nonempty directories)
- "See if file is excluded before reporting an error": make sure the file would
be excluded whether or not it is a directory.

Please test and comment.  Wayne, I've been rather bold with my changes, and you
may want to throw out some of them, but let's talk about it.

This patch has some rather trivial conflicts with the ACL patch.  I will write
up corresponding man page changes next.  Maybe I will also write a test case.

Configure bugmail:
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

More information about the rsync mailing list