BugReport: rsync fails it's own "regression" test "chmod-option"

Matt McCutchen hashproduct+rsync at gmail.com
Sat Dec 16 00:11:39 GMT 2006


On 12/15/06, Hugh Daniel <hugh at road.toad.com> wrote:
> When run as root the
> "chmod-option" test allays fails, and fails across many versions of
> Linux, RedHat-7.3, SuSE-10.0, Debian-Etch in the same way.
> [Matt snipped here and PGP-unescaped below]
>  drwxrwxr-x            0      0.10          3 2006-12-15 21:16:53 .
> --rw-rw-r--            0      0.10          1 2006-12-15 21:16:53 ./bar
> -drwxrwxr-x            0      0.10          2 2006-12-15 21:16:53 ./foo
> +-rw-rw-r--            0      0.0           1 2006-12-15 21:16:53 ./bar
> +drwxrwxr-x            0      0.0           2 2006-12-15 21:16:53 ./foo

Indeed, the test is invalid.  The trouble is that the test suite
starts an rsync daemon, instructs it to use uid and gid 0, and expects
files created by the test suite to have the same user/group owners as
those created by the daemon.  This expectation is valid for non-root
users (because the daemon fails to change its uid and gid) and for
root with a default group of root but not for root with a default
group of wheel, as you saw.  The fix is to tell the rsync daemon to
run as the same uid and gid as the user invoking the testsuite.
Wayne, a patch for the test is attached.

Matt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: testsuite-daemon-same-uid-gid.diff
Type: text/x-patch
Size: 505 bytes
Desc: not available
Url : http://lists.samba.org/archive/rsync/attachments/20061215/84534bcf/testsuite-daemon-same-uid-gid.bin


More information about the rsync mailing list