DO NOT REPLY [Bug 3825] rsync won't delete directory with excluded files

[samba-bugs at samba.org]

https://bugzilla.samba.org/show_bug.cgi?id=3825





------- Comment #11 from hashproduct+rsync at gmail.com  2006-08-25 17:25 MST -------
(In reply to comment #10)

Thanks for testing the patch!

> I would also argue that the message should be emitted regardless of -v options
> since it indicates that rsync is unable to perform an expected operation.

I disagree.  Rsync is not /unable/ to delete the directory; it merely chooses
not to delete the directory because you gave it a protect filter (or an exclude
filter that implies a protect filter).  It's not an error when one requested
behavior (the protect filter) takes priority over another (--delete).

You have to decide what you want.  If you want rsync to delete the directory,
use a hide filter instead of an exclude filter, or give the parent-protect
flag.  If you want rsync not to delete the directory, continue to use an
exclude filter; if you want it to remind you why it isn't deleting the
directory, use -vv.

> {dirname}/ cannot be deleted because it contains a protected/excluded file

Sure, that is clearer to users, but I would change "cannot be deleted" to "was
not deleted".

> Now we wait for Wayne to chime in with his opinion...

And we wait... :)


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.