DO NOT REPLY [Bug 3718] RSync should verify permission/time before commiting a change

[samba-bugs at samba.org]

https://bugzilla.samba.org/show_bug.cgi?id=3718





------- Comment #2 from yair.lenga at citigroup.com  2006-04-24 15:22 MST -------
(In reply to comment #1)

> I think it is better to keep the file and let a future rsync run try to fix any
> failed ownership problems.

Waine - I hope that you will reconsider. See examples below.

I would vote to have correct files in the repository, instead of leaving
incorrect data that may (or may not) be fixed in future runs. Having incorrect
data (even  for few hours) can have "chain" effect, when data can not be easily
recalled.

I agree that the initial permissions will not create security problem. However,
incorrect permissions may easily break existing processes that expect
read-access to the files in the user directory, or when files are shared
between accounts: binaries will not be executable, etc.

The timestamp is more serious issue - by default, the time stamp is very new,
which will make it very hard to find the most updated version of several
repositories. In particular, it will prevent future 'rsync --update' from
working.

The last serious issue is the ownership. I'm using rsync in server mode (root)
to sync repository with multiple users. Leaving "root/other 0700" files in the
directory, prevented the users from updating his own files (which took us a lot
of time to debug).


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.