[Bug 3174] Patch for specifying zlib compression level

samba-bugs at samba.org samba-bugs at samba.org
Mon Oct 17 20:49:15 GMT 2005


https://bugzilla.samba.org/show_bug.cgi?id=3174


wayned at samba.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED




------- Additional Comments From wayned at samba.org  2005-10-17 13:49 -------
The problem with using an optional arg with popt is that a following option
(e.g. "--compress -v") treats the following option as the arg to --compress
(which seems to be what your popt patch fixes).  Since we want to support using
a shared popt library, that means that optional args can't be used.

Also, your changes to batch.c created an incompatible batch-file format.  To
remain compatible, you need to make sure that the existing 0 and 1 values in
batch files continue to mean what 0 and -1 mean in your patch.

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.


More information about the rsync mailing list