odd behaviour change (2.6.3 > 2.6.4pre3)

Wayne Davison wayned at samba.org
Thu Mar 17 00:53:01 GMT 2005


On Wed, Mar 16, 2005 at 07:29:39PM -0500, Erik Jan Tromp wrote:
> [erik at lithium ~]$ rsync-2.6.4pre3 rsync://helium/slackware/
> <snip motd>
> skipping directory /.

This is a result of a 1-character typo in options.c:

--- options.c	14 Mar 2005 17:30:13 -0000	1.253
+++ options.c	17 Mar 2005 00:50:22 -0000
@@ -1301,7 +1301,7 @@ void server_options(char **args,int *arg
 	/* This is a complete hack - blame Rusty.  FIXME!
 	 * This hack is only needed for older rsync versions that
 	 * don't understand the --list-only option. */
-	if (list_only == 1 && recurse)
+	if (list_only == 1 && !recurse)
 		argstr[x++] = 'r';
 
 	argstr[x] = 0;

I've checked this in.  Thanks for the report!

..wayne..


More information about the rsync mailing list