Rsync cross-compilation problem

Wayne Davison wayned at samba.org
Mon Jan 24 08:03:00 GMT 2005


On Mon, Jan 24, 2005 at 01:07:28AM -0600, John Van Essen wrote:
> shouldn't the compiler abort with a meaningful error message in the
> #else of the #if sequence?

The idea is to still allow rsync to run with 32-bit offsets if the
maximum filesize for a system fits in 32 bits.  I haven't seen anyplace
where the code is adversely affected by falling back to 32 bits that
isn't already double-checked to ensure that the necessary 64 bits are
actually present (for instance, the md4 calculation avoids this problem
by using two 32-bit numbers to calculate its 64-bit total).  Also, there
are some systems where the define that use that "off_t" define to get
the system's 64-bit data type.

..wayne..


More information about the rsync mailing list