--bwlimit doesn't work for daemon mode

Wayne Davison wayned at samba.org
Thu Jan 13 19:19:54 GMT 2005


On Thu, Jan 13, 2005 at 09:12:12AM +0000, uwe at ohse.de wrote:
> Some time after 2.6.0 the --bwlimit code was enhanced, but the code now
> doesn't work anymore when you set the bandwidth limit for the daemon

First, thanks for the patch -- they are always appreciated!  However,
your patch is identical to the one suggested in this message:

http://www.mail-archive.com/rsync@lists.samba.org/msg11850.html

The conversation then went on to mention that --bwlimit has never really
been a daemon option, and only coincidentally set a default bandwidth-
limit value for a daemon (in older versions).  However, that value could
be exceeded by the client (which is what your patch re-enables).  Though
the cited mailing-list thread doesn't mention it, the code in CVS now
has a better --bwlimit option for the daemon that makes this value an
enforced upper-limit on transfers from the daemon.  (Nothing tries to
limit transfers into a daemon other than the a user-specified --bwlimit
option.)

Note that the cited patch works fine for restoring the old --bwlimit
behavior to 2.6.3, and in fact, some Linux distributions (such as
Debian) have used it to patch their packaged version of 2.6.3.

..wayne..


More information about the rsync mailing list