[Bug 1812] fuzzy not working in 2.6.3-pre{1,2}

samba-bugs at samba.org samba-bugs at samba.org
Thu Sep 23 15:47:32 GMT 2004


https://bugzilla.samba.org/show_bug.cgi?id=1812


wayned at samba.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




------- Additional Comments From wayned at samba.org  2004-09-23 08:47 -------
This was a very simple bug in the g2r-basis-filename.diff: the line that checked
if whole_file was non-zero needed to be updated to check if whole_file was
greater than 0.  I missed this in my testing because I tested local copies using
the --no-whole-file option.

So, temporary workaround: specify --no-whole-file.

Proper fix, get an updated version of the g2r-basis-filename patch (or just
manually add "> 0" to the "if (dry_run || whole_file) {" line) and all should be
well.

I did also check in an updated version of the fuzzy.diff patch, but that was
mainly to ensure that the user can't try to specify --inplace with --fuzzy (it
also got rid of some "might be used unitialized" compiler warnings, but they
were not indicative of an actual problem, just an annoyance).

Thanks for the excellent bug report!

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.


More information about the rsync mailing list