rsync 2.6.2 with Posix socket on HP-UX

Wayne Davison wayned at
Thu Sep 16 17:25:15 GMT 2004

On Fri, Sep 03, 2004 at 03:40:33PM +0900, Nobu Takahashi wrote:
> Then it hits "goto failed" and there "listener" is closed as it is
> not -1 and fails.  This overrides the errno to EBADF.  I think -1
> should be set to "listener" after the close() to avoid this problem.

Yes, that is a bug.  I've checked in your suggest fix.

> The real problem is that "fd[1]" is non-blocking for the second
> connect().  I think it can wait till the connection is made and this
> fixes the problem that the second connect() returns EINPROGRESS.
> Simply moving "set_blocking(fd[1])" before the connect() solves this
> problem.

I hope that is a compatible fix for other systems.  I'm trying it out
on the rsync build farm and it will be in 2.6.3pre2 (coming out soon).

Thanks for the report!


More information about the rsync mailing list