[PATCH] fix read-batch SEGFAULT [WAS: --write-batch just hangs?]

Chris Shoemaker chris.shoemaker at cox.net
Wed May 5 00:14:22 GMT 2004

On Fri, Apr 30, 2004 at 10:32:18AM -0700, Wayne Davison wrote:
> On Thu, Apr 29, 2004 at 05:00:32PM -0400, Chris Shoemaker wrote:
> > Instead of any update, with the --write-batch=mytest argument, rsync just hangs.
> The batch code is still experimental (as noted in the man page), so I'm
> not surprised by this.  The code still needs someone to test it and fix
> it to make it solid.  Any volunteers?
> ..wayne..

I'd like to see it working, so I'll see how much I can help.

Just so I'm on the right page, AFAICT, batch mode doesn't work _at all_.  
If anyone knows differently, please let me know.  I've think I've tried 
almost every possible test, including the one in the man page.  Anyway, 
this patch does allow me to read a batch written locally.  That's a 
start, at least.

Next, I'm going to see if I can figure out the hang that I mentioned 

-------------- next part --------------
Index: generator.c
RCS file: /cvsroot/rsync/generator.c,v
retrieving revision 1.79
diff -r1.79 generator.c
> extern int read_batch;
< 	if (whole_file == 0 || write_batch)
> 	if (whole_file == 0 || write_batch || read_batch)

More information about the rsync mailing list