[Bug 1529] 32bit rollover problem rsyncing files greater than 4GB in size

[samba-bugs at samba.org]

https://bugzilla.samba.org/show_bug.cgi?id=1529





------- Additional Comments From lnds at hotmail.com  2004-07-31 03:48 -------
I was getting bitten by the same bug, im my case a 4.1GB file rolling over in
100MBs.  I've applied the patch and the problem in generate_and_send_sums is
indeed fixed, but it appears to have just moved onto another much graver bug
which causes nothing to get transfered:

rsync
rsync.planetmirror.com::fedora/linux/core/test/2.90/i386/iso/FC3-test1-i386-DVD.iso
-azvvv .

opening tcp connection to rsync.planetmirror.com port 873

  Welcome to PlanetMirror's rsync service.


  You can find a web front end to this archive at:

       http://planetmirror.com

  You can also access this service via FTP at

        ftp://ftp.planetmirror.com


  If you are a regular PM user, please consider supporting PM by
  subscribing to a Premium or PremiumDownload account via the
  web front end.


receiving file list ...
recv_file_name(FC3-test1-i386-DVD.iso)
received 1 names
done
recv_file_list done
get_local_name count=1 .
recv_files(1) starting
generator starting pid=2243 count=1
delta transmission enabled
recv_generator(FC3-test1-i386-DVD.iso,0)
generating and sending sums for 0
count=66400 rem=4729 blength=66384 s2length=4 flength=4407835945
generate_files phase=1
recv_files(FC3-test1-i386-DVD.iso)
FC3-test1-i386-DVD.iso
recv mapped FC3-test1-i386-DVD.iso of size 4407835945
rsync: connection unexpectedly closed (89 bytes read so far)
rsync error: error in rsync protocol data stream (code 12) at io.c(359)
_exit_cleanup(code=12, file=io.c, line=359): about to call exit(12)
rsync: connection unexpectedly closed (69 bytes read so far)
rsync error: error in rsync protocol data stream (code 12) at io.c(359)
_exit_cleanup(code=12, file=io.c, line=359): about to call exit(12)




(In reply to comment #1)
> Your bug report made the problem easy to find.  I've checked in a fix to CVS,
> but you can fix your current source by changing the "size_t" to "OFF_T" in the
> generate_and_send_sums() function in generator.c.  It should look like this:
> 
> static void generate_and_send_sums(struct map_struct *buf, OFF_T len, int f_out)
> 
> Then, recompile, install, and the problem should be gone.



-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.