[PATCH] Batch-mode rewrite

Chris Shoemaker c.shoemaker at cox.net
Thu Jul 22 23:27:28 GMT 2004


On Thu, Jul 22, 2004 at 07:01:12PM -0400, Chris Shoemaker wrote:
> On Thu, Jul 22, 2004 at 06:36:27PM -0700, Wayne Davison wrote:
> > And don't forget the hard-link post-processing -- it would also need to
> > happen after the receiver finished its job.
> 
> Ok, it's late and this new patch seems like the simplest solution of
> all, so there's probably something very wrong with it.  Basic idea:
> move hard-link post-processing and directory permission tweaks from
> generate_files() to recv_files().  Then there's no syncing issues,
> because receiver cleans up when receiver's done.  Uh, right?  :)

Of course, simple isn't so great when it doesn't work.  :)

I see now that the hard-link post-processing looks pretty firmly
attached to the generator, with the 4 hard_link_check() calls in
recv_generator().  I'll look at this some more later.

-chris

> 
> Even with the index notification, this kind of decoupling of recv and
> generator makes sense, don't you think?
> 


More information about the rsync mailing list