[PATCH] Batch-mode rewrite

Wayne Davison wayned at samba.org
Tue Jul 20 18:01:10 GMT 2004

On Mon, Jul 19, 2004 at 05:35:24PM -0400, Chris Shoemaker wrote:
> If I understand correctly, there's no reason to save the list into the
> BATCH file.  It only needs be in BATCH.sh.

Yes.  I think that is the most flexible way to go and that is what the
current CVS code is doing.

> Is there much performance impact specifying --excludes when they won't
> be used?

No, the receiving side (which is what the batch-reading process is)
would not even notice that the list was there unless it ran a --delete
without --delete-excluded.  So, my latest code includes the exclude list
in the BATCH.sh file anytime it was specified, even if it might not be
needed.  This will allow a user to add a --delete into the BATCH.sh file
after the fact or even to edit the list.

I think this implementation makes it easy to re-run the batch (since no
data outside the BATCH.sh and BATCH files is needed) while still being
flexible for "power users" that want to tweak things.


More information about the rsync mailing list