possible bug with --files-from and --no-relative options
Wayne Davison
wayned at samba.org
Wed Dec 22 09:27:25 GMT 2004
On Wed, Dec 22, 2004 at 01:46:48PM +1100, aaron.duncan at centrelink.gov.au wrote:
> if it is indeed a bug, then hopefully it may raise it to someone's
> attention for fixing in a future release.
Good catch! Rsync needs to send the --no-relative option to the remote
rsync when it has sent the --files-from option (it avoids doing that
when --files-from was not sent to the other side because it allows a
sender to send a files-from-generated list to an older rsync version).
I've just checked-in a fix for this into the CVS version. I'll also
attach the patch, which should be easy to apply to 2.6.3 or earlier
(though I didn't check to see if it applies cleanly to older versions).
Thanks for the very complete bug report! It made it a snap to figure
out what was wrong and fix it.
..wayne..
-------------- next part --------------
--- options.c 8 Dec 2004 17:29:54 -0000 1.191
+++ options.c 22 Dec 2004 09:08:17 -0000
@@ -1236,6 +1236,8 @@ void server_options(char **args,int *arg
args[ac++] = "--files-from=-";
args[ac++] = "--from0";
}
+ if (!relative_paths)
+ args[ac++] = "--no-relative";
}
*argc = ac;
More information about the rsync
mailing list