rsync and broken symlinks

Dmitry V. Levin ldv at altlinux.org
Thu Dec 16 23:33:35 GMT 2004


Hi,

On Thu, Dec 16, 2004 at 10:27:20PM +0100, Paul Slootman wrote:
> On Thu 16 Dec 2004, Wayne Davison wrote:
> > 
> > As for the fix, one could argue that "ignore nonreadable" has a bug in
> > it when dealing with symlinks -- if readlink() worked, the symlink was
> > readable, so there is no need to call access() on it.  The appended
> > patch changes this so that rsync doesn't ever use access() on a symlink.

Surely good fix, thanks.

> Just to be certain - readlink() is only called if --copy-links is NOT
> specified? In that case, I agree.

Yes, if copy_links is set, then stat() is called instead.


-- 
ldv
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.samba.org/archive/rsync/attachments/20041217/b183550f/attachment.bin


More information about the rsync mailing list