[Bug 1582] rsync dry run cannot find missing folders, contradicts actual run.

samba-bugs at samba.org samba-bugs at samba.org
Thu Aug 5 21:31:30 GMT 2004


https://bugzilla.samba.org/show_bug.cgi?id=1582





------- Additional Comments From wayned at samba.org  2004-08-05 14:31 -------
(In reply to comment #3)
> Are there other patches you have used on generator.c in the past
> that I need to be aware of?

All the patches I post to bugzilla are relative to the CVS version, so it's not
surprising that you ran into a problem if you tried to patch an earlier release.
You can either snag the CVS version (for instance, the latest nightly tar file
from the rsync website has the fix already applied).  Or you can adapt the fix
for your version.

>From the code you cited, here's how I would adapt the fix:

	if (verbose > 2)
		rprintf(FINFO,"recv_generator(%s,%d)\n",fname,i);

	if (dry_run > 1) {
		statret = -1;
		errno = ENOENT;
	} else
		statret = link_stat(fname,&st);

	if (only_existing && statret == -1 && errno == ENOENT) {
		/* we only want to update existing files */

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.


More information about the rsync mailing list